Skip to content

Conversation

@jabrena
Copy link
Contributor

@jabrena jabrena commented Nov 7, 2025

Adding the missing Devcontainer configuration.

Please include in the description above the list of GitHub issues this Pull Request addresses in the following format:

Juan Antonio

@jabrena jabrena changed the title Adding missing documentation about the purpose of Devcontainers's sup… Adding missing documentation about the purpose of Devcontainers's support Nov 7, 2025
@jabrena
Copy link
Contributor Author

jabrena commented Nov 7, 2025

Second iteration: #50865

@jabrena
Copy link
Contributor Author

jabrena commented Nov 11, 2025

🙋🏻‍♂️@geoand

@geoand
Copy link
Contributor

geoand commented Nov 11, 2025

I'm completely clueless as to why CI is behaving the way it is. @gastaldi any ideas?

@gastaldi
Copy link
Contributor

@geoand probably because this file path isn't matched in https://github.com/quarkusio/quarkus/blob/main/.github/workflows/ci-sanity-check.yml

@geoand
Copy link
Contributor

geoand commented Nov 11, 2025

So we just need to update that workflow file?

@gastaldi
Copy link
Contributor

Yes, I believe so

@geoand
Copy link
Contributor

geoand commented Nov 11, 2025

Thanks! Let's see what happens

@quarkus-bot quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Nov 11, 2025

## Getting Started

If you visit the project in Github: https://github.com/jabrena/quarkus in the main view, exist a Green button named `Code` if you click in the dropdown, you will see the option `Codespaces` so, if you click in the button `Open in Codespaces`, you will open a new Tab in your web browser to load Quarkus in Codespaces.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you visit the project in Github: https://github.com/jabrena/quarkus in the main view, exist a Green button named `Code` if you click in the dropdown, you will see the option `Codespaces` so, if you click in the button `Open in Codespaces`, you will open a new Tab in your web browser to load Quarkus in Codespaces.
If you visit the project in Github: https://github.com/quarkusio/quarkus in the main view, exist a Green button named `Code` if you click in the dropdown, you will see the option `Codespaces` so, if you click in the button `Open in Codespaces`, you will open a new Tab in your web browser to load Quarkus in Codespaces.

Copy link
Contributor Author

@jabrena jabrena Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upps , I go with it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the bad link

@jabrena
Copy link
Contributor Author

jabrena commented Nov 11, 2025

@gastaldi maybe it is something that it should be in the onboarding doc like to maintain the list of files in the https://github.com/quarkusio/quarkus/blob/main/.github/workflows/ci-sanity-check.yml ?

@geoand mabe with the link updated, we could continue right?

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand merged commit 491d127 into quarkusio:main Nov 11, 2025
3 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.30 - main milestone Nov 11, 2025
@jabrena jabrena deleted the feature/devcontainers-docs-strikes-backs branch November 11, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants