-
Notifications
You must be signed in to change notification settings - Fork 3k
Adding missing documentation about the purpose of Devcontainers's support #50921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding missing documentation about the purpose of Devcontainers's support #50921
Conversation
|
Second iteration: #50865 |
|
🙋🏻♂️@geoand |
|
I'm completely clueless as to why CI is behaving the way it is. @gastaldi any ideas? |
|
@geoand probably because this file path isn't matched in https://github.com/quarkusio/quarkus/blob/main/.github/workflows/ci-sanity-check.yml |
|
So we just need to update that workflow file? |
|
Yes, I believe so |
|
Thanks! Let's see what happens |
.devcontainer/README.md
Outdated
|
|
||
| ## Getting Started | ||
|
|
||
| If you visit the project in Github: https://github.com/jabrena/quarkus in the main view, exist a Green button named `Code` if you click in the dropdown, you will see the option `Codespaces` so, if you click in the button `Open in Codespaces`, you will open a new Tab in your web browser to load Quarkus in Codespaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| If you visit the project in Github: https://github.com/jabrena/quarkus in the main view, exist a Green button named `Code` if you click in the dropdown, you will see the option `Codespaces` so, if you click in the button `Open in Codespaces`, you will open a new Tab in your web browser to load Quarkus in Codespaces. | |
| If you visit the project in Github: https://github.com/quarkusio/quarkus in the main view, exist a Green button named `Code` if you click in the dropdown, you will see the option `Codespaces` so, if you click in the button `Open in Codespaces`, you will open a new Tab in your web browser to load Quarkus in Codespaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upps , I go with it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the bad link
|
@gastaldi maybe it is something that it should be in the onboarding doc like to maintain the list of files in the https://github.com/quarkusio/quarkus/blob/main/.github/workflows/ci-sanity-check.yml ? @geoand mabe with the link updated, we could continue right? |
geoand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Adding the missing Devcontainer configuration.
Please include in the description above the list of GitHub issues this Pull Request addresses in the following format:
Juan Antonio